Sasha Sheikin
Sasha Sheikin
This PR resolves https://github.com/trinodb/trino/issues/12833
> One idea which I was thinking was to expose all internal columns as a ROW type with multiple fields instead of separate column per field - that way you...
> What if we could generate the name of these meta-columns based on the table structure. Like if we have column `_timestamp_n` then we could generate the metacolumn name as...
>Looks like current exception is coming somewhere from core/engine (not from connector). So maybe we can add such check on column collision inside connector, with more detailed description, not to...
@hashhar @vlad-lyutenko @Praveen2112 All comments are addressed. Please take a look one more time.
ci / pt (default, suite-6-non-generic, ) (pull_request) https://github.com/trinodb/trino/actions/runs/3111929833/jobs/5045112147 ``` tests | 2022-09-22 23:00:02 INFO: FAILURE / io.trino.tests.product.kafka.TestKafkaPushdownSmokeTest.testCreateTimePushdown (Groups: profile_specific_tests, kafka) took 6.0 seconds tests | 2022-09-22 23:00:02 SEVERE: Failure cause:...
@hashhar I believe there no outstanding questions left here. Please approve and merge.
@wendigo please approive
 Restarting checks