Skye Shaw
Skye Shaw
Closing . If the above `git-link*` options do not work for you feel free to reopen.
Hi @futuro, thanks for the PR. This is definitely something that's needed. I believe my concern with the other PRs was compatibility in that the signatures and/or return value must...
Hi @futuro, sorry for the holdup > is your question about whether git-link-url can be called as a pure function, versus needing to be called inside the buffer you want...
> Is there a blocker for this feature to be merged? Thanks It does not implement [a standalone version](https://github.com/sshaw/git-link/pull/69#issuecomment-631768670) of `git-link-url` (or similar). In its current form its return value...
Hi, Thanks for getting back to this! > I've noticed that git-link works in the same way as my change ... > and that much of git-link depends on global...
> I would say this is general principle for functions, etc...: don't depend on global state. Though we can depend on the output of `git`, which is sorta global state....
> ... what's the goal of the optional arg use-branch? That is supposed to be the equivalent of sorts of [`git-link-use-commit`](https://github.com/sshaw/git-link#git-link-use-commit). Currently the default is to generate the link using...
Thanks a lot. I will have a looksy at or before Christmas Day 🎅🤶
Hi, @futuro, lookin' good. Aside from my 2 comments I would squash this PR into a single commit. Merry Christmas! 🎄
> Just to clarify, are you asking me to squash all the commits in this PR, or are you saying that you're going to do a squash merge afterwards? Squash...