Shane Smiskol
Shane Smiskol
Works pretty well with hysteresis for the 22 CamryH which is actually 1.08
It appears different GM camera platforms use different `ECMAcceleratorPos->BrakePedalPos` to cancel. Our Bolt for example is around 8, however the Silverado is around 20. - Our Bolt (threshold of 8):...
Taco sauce: https://pixabay.com/vectors/taco-wrap-food-mexican-fast-food-155812
Stock GM (ASCM and CAM platform) enables on falling edge of set, but rising edge of resume. Since openpilot enables on falling edge of both, you can fault the ECM...
- [ ] Test and gather FW versions - [x] ~~Handle alt gears, buttons, and accelerator~~ we already do. brake also looks good
Hyundai already handles this, this just makes it generic since other makes can suffer from this as well (GM included).
- removes todo originally from `update_v_cruise`: moves updating logic to state_control with proper handling - update button timers and states before everything, removes need to check current and past standstill