Shane Smiskol

Results 295 issues of Shane Smiskol

This is causing controls mismatches for some users, including at least a Maverick and Escape. Haven't hit it on our Bronco yet however. I checked all three message checksums we...

bug
bounty
car
ford

hit this while restarting Bronco many times in a row to test a signal. camerad crashed every subsequent startup 54827bf84c38b14f|2023-05-11--22-06-44 Related errorLog: ``` {'errorLogMessage': '{"msg": {"tombstone": "system/camerad/camerad - Signal: 6...

bug

Catch cases where camera is faulted, but not PCM. Just opened to verify with data later

car
ford

Camera sends alerts over GMLAN which we can't control, so you'll get messages like "hill too steep" and other strange alerts that don't affect anything that are caused by mismatches...

enhancement
car
gm

Basically, get panda's `controlsAllowed` to rise but make it a noEntry to openpilot. Then around 2 seconds later, engage. For example in a button enable car: press set with seatbelt...

bug
controls

adds typing to most used functions

fingerprint
cleanup

simplify by bringing funcs in dicts out into an if statement and using correct mph to kph conversion. - [ ] tests

Could be a diff of torque, max torque, or angle rate https://connect.comma.ai/f299d0a03c4e965d/1685509313071/1685509343277 https://connect.comma.ai/f299d0a03c4e965d/1685509362131/1685509446705 https://connect.comma.ai/f299d0a03c4e965d/1685509216391/1685509226635

bug
car
honda

needs testing
bugfix
car
honda

just to see what a PR to add a new brand would look like!

enhancement
fingerprint
car
ford