Shane Smiskol

Results 295 issues of Shane Smiskol

@deanlee is there a better way to do this? ![Screenshot from 2023-01-26 20-42-58](https://user-images.githubusercontent.com/25857203/215011122-4ffad899-f153-42d7-88be-909b63d84c8c.png)

enhancement
tools

Not really blending :(, just winds down torque as soon as driver touches wheel. If you set just actuation bit to 0 but keep curvature, it will silently fault and...

car
ford

this branch is stemmed from the first hkg branch lol, will clean up

enhancement
fingerprint
honda

After taking a look at the Toyota FW versions, it looks like there's some sort of pattern here, so there may be potential for doing some heuristics on just the...

fingerprint
car
toyota

Not sure if this will work for all cars, I recall some cars have both messages but FCA is still not used, but I could be mis-remembering If this works,...

cleanup
car
hyundai

Similar to https://github.com/commaai/openpilot/pull/27322, but this should be guaranteed. I'll verify on data and merge! Haven't checked extensively, but I believe we can merge a few platforms with no other differences...

cleanup
car
hyundai

Still a draft. There are some cars that use the same platform codes, but are fundamentally different as far as openpilot is concerned. One big example are the older Ioniqs;...

enhancement
fingerprint
car
hyundai

A lot of the platforms in this list we got rid of here: https://github.com/commaai/openpilot/pull/27323 are also in this list, so we can't merge many platforms until we auto-detect this list...

cleanup
car
hyundai

Found when trying to detect FCA, we were never logging AEB/FCW on this car properly. `fec0d754d02e943e|2023-01-04--17-42-05--10 KIA OPTIMA 4TH GEN FACELIFT any(fca_warn)=True, any(scc_warn)=False` ![Screenshot from 2023-02-14 00-03-25](https://user-images.githubusercontent.com/25857203/218675931-522c0401-24c2-43f3-b53d-4cc41fe513b1.png) ![Screenshot from 2023-02-14...

cleanup
car
hyundai