JFoenix icon indicating copy to clipboard operation
JFoenix copied to clipboard

JDK 12 incompatible

Open chengenzhao opened this issue 5 years ago • 66 comments

Hi: Today JDK 12 is released and one interesting change is they make javafx.scene.control.skin.TextFieldSkin members private thus for JFoenix we will get some exception like: java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextFieldSkin cannot access a member of class javafx.scene.control.skin.TextFieldSkin with modifiers "private" at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:355)

so any ideas how we should fix this problem?

chengenzhao avatar Mar 20 '19 03:03 chengenzhao

and I guess this problem has something to do with this issue: https://bugs.openjdk.java.net/browse/JDK-8207942

chengenzhao avatar Mar 20 '19 03:03 chengenzhao

Hi, we did face the relevant problem with the same component JFXTextFieldSkin while launching the application.

Here is the exception. Exception in thread "JavaFX Application Thread" java.lang.NullPointerException at com.jfoenix.skins.JFXTextFieldSkin.updateTextPos(JFXTextFieldSkin.java:109) at com.jfoenix.skins.JFXTextFieldSkin.layoutChildren(JFXTextFieldSkin.java:93) at javafx.scene.control.Control.layoutChildren(Control.java:601)

java.version : 12 java.vm.version : 12+33

we use java fx bundle 12

Thought this is relevant. Let me know if this needs to be created as a new issue

cupendra avatar Mar 20 '19 11:03 cupendra

I tried looking into it but @jfoenixadmin it seems that the branch JFoenix-9.0.0 hasn't been kept up to date since August 2018 :-(

I tried updating it but went over my head.

micheljung avatar Mar 30 '19 12:03 micheljung

@micheljung no worries, I'll do the merge now. However I'm not sure this will fix the compatibility with JDK 12

jfoenixadmin avatar Apr 03 '19 13:04 jfoenixadmin

Same problem here with jfoenix 9.0.9 Has anybody figured out how to fix it?

Terkea avatar Jun 02 '19 20:06 Terkea

I am also having a problem with jfoenix 9.0.9 and JDK 12

TheRedSpy15 avatar Jun 19 '19 01:06 TheRedSpy15

@jfoenixadmin not sure if you saw this already:

https://stackoverflow.com/a/55892520

TheRedSpy15 avatar Jun 19 '19 02:06 TheRedSpy15

@TheRedSpy15 that's how we are using reflection to access private fields. however I suspect that the field either renamed or removed thus causing this issue.

jfoenixadmin avatar Jul 04 '19 13:07 jfoenixadmin

I am facing this issue as well java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextAreaSkin cannot access a member of class javafx.scene.control.skin.TextAreaSkin

sanjitmisra avatar Jul 15 '19 02:07 sanjitmisra

@jfoenixadmin when will get a fix for this :(

rnayabed avatar Jul 19 '19 17:07 rnayabed

is this fixed??

mmahapat avatar Oct 10 '19 07:10 mmahapat

Not fixed yet

kowlown avatar Oct 18 '19 20:10 kowlown

Am also faced with the same issue

java.lang.IllegalAccessException: class com.jfoenix.skins.JFXTextFieldSkin cannot access a member of class javafx.scene.control.skin.TextFieldSkin with modifiers "private"

Dosibo-dot avatar Dec 10 '19 20:12 Dosibo-dot

did any one resolve this issue ?

pramudKumarage avatar Dec 22 '19 06:12 pramudKumarage

Any fix?

anis-dr avatar Jan 21 '20 21:01 anis-dr

any fix ?

aviollet avatar Jan 31 '20 09:01 aviollet

Are there any plans for making JFoenix compatible with versions of Java greater than 11?

astonbitecode avatar Feb 07 '20 08:02 astonbitecode

any fix to the access block to JFXTextfield and JFXPassword in jdk12?

OhenebaAduhene avatar Feb 28 '20 11:02 OhenebaAduhene

@jfoenixadmin We need some kind of a fix for this bug please, I don't want to downgrade to jdk11 just for this issue :(

ysyesilyurt avatar Apr 25 '20 22:04 ysyesilyurt

Same here. Won't use the library as I am on JDK 14 / JavaFX 12

seinecle avatar Apr 26 '20 16:04 seinecle

Same here

class com.jfoenix.skins.JFXTextFieldSkin cannot access a member of class javafx.scene.control.skin.TextFieldSkin (in module javafx.controls) with modifiers "private"

I am on JDK 14 and JavaFx 14, May be I have to downgrade to JDK 11?

viewv avatar May 06 '20 14:05 viewv

@viewv yes currently that is the only solution

TheRedSpy15 avatar May 08 '20 00:05 TheRedSpy15

any fix ?

rruffer avatar May 09 '20 03:05 rruffer

please fix it.

mohammadne avatar May 13 '20 11:05 mohammadne

PLEASE!!!!!!!!

richidubey avatar Jun 03 '20 15:06 richidubey

It's dead Jim

kowlown avatar Jun 03 '20 15:06 kowlown

no news on the subject?

rruffer avatar Jun 03 '20 15:06 rruffer

Hallelujah, I'm pushing the fix today to JFoenix 9 branch :p, I'll update the maven jars later today to x.x.10

jfoenixadmin avatar Jun 04 '20 08:06 jfoenixadmin

Amazing!! Regards, Ngacho.

"A painting is never finished-It simply stops in interesting places." Paul Gauguin.

On Thu, 4 Jun 2020 at 11:12, JFoeniX [email protected] wrote:

Hallelujah, I'm pushing the fix today to JFoenix 9 branch :p

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jfoenixadmin/JFoenix/issues/955#issuecomment-638686054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPONSMBBFRV7POAGFORR33RU5JP5ANCNFSM4G7ZDIJA .

ngacho avatar Jun 04 '20 09:06 ngacho

Hallelujah, I'm pushing the fix today to JFoenix 9 branch :p, I'll update the maven jars later today to x.x.10

YOU ROCK! THANKS !!!

seinecle avatar Jun 04 '20 11:06 seinecle