Stefan Seritan

Results 75 comments of Stefan Seritan

Thanks for your effort on this Corey. I'll do a full review of this PR again later this week, but my 30 second skim does leave me mildly concerned about...

I see. I didn't realize it was a Qibo-side change. Thanks for looking into it more in-depth than I did. Yes, in that case, I agree that it should be...

This is a known bug that I think is fixed on the tip of `develop`. The bug is actually a result of a switch from normalized to unnormalized Paulis in...

Maybe try the tip of develop. That way you can get all the up-to-date bugfixes as we fix the issues you are bringing to our attention? :) (Also let me...

Yes we have considered running the Jupyter notebooks in CI, it just hasn't been a high priority. I'll revisit that the next time I have a few extra cycles. :)

I expect this should be fixed by doing `target_model.sim = "matrix"` before `find_fiducials()`. If this works, we can try to find a more intuitive behavior/warning for users. **More details** The...

Yes, there are quite a few options for fiducial/germ selection to play with. The best place to start would be the fid/germ selection [tutorial](https://github.com/pyGSTio/pyGSTi/blob/master/jupyter_notebooks/Tutorials/algorithms/advanced/GST-FiducialAndGermSelection.ipynb). As for the 2Q model, I'll...

They are actually not linked, and in fact, the modelpacks don't necessarily correspond to edesigns generated only with the coded fiducial/germ selection algorithms. For example, the 1Q modelpacks all have...

I think we'd be happy to have a call and talk about how to generate a reasonable GST design. Often knowing a little about the pecularities/physics goes a long way...

This has been currently avoided by limiting Qibo to version 0.1.7 in setup.py. Long-term, we probably want to reach out to the Qibo developers and understand why they made this...