Scott Seago

Results 118 comments of Scott Seago

I've added a section near the end which references the various PRs that have been written relating to this with some notes on what would need to be reverted, what...

One note on implementation schedule. The CRD changes and v2 plugin versions should be the highest priority for implementation first. CRD changes are all minor (and backwards-compatible) -- new status.phase...

Are we ready to merge this design? I think all of the feedback has been responded to.

@blackpiglet I responded to that above when it was mentioned here. In summary, I think it shouldn't be part of this proposal. It's not something needed for the identified use...

Actually, I think the current excludes/excludes *do* apply to cluster-scoped resources. If you include PersistentVolumes in excludedResources, then I don't think any will be backed up. If you have an...

So setting includeClusterResources to nil *does* include some cluster resources, but it's limited to those resources that are directly relevant to other resources being backed up (this handles the usual...

As for "no namespaced resources but all cluster resources", I wonder whether we can handle this by just excluding all namespaces while seting includeClusterResources to `true`. I know that wildcards...

So one thing to consider -- if we were to implement your proposal, we'd need a different name. Your proposal doesn't account for the nil value of includeClusterResources -- i.e....

@nwakalka Were both velero installations the same version? Two independent velero installations should still work as of 1.9. Nothing has been changed that was intended to break this, although it's...

@reasonerjt It was mentioned on yesterday's community call that we may want to also use the filter for deciding which PVs to back up with restic/kopia vs. snapshots.