connaisseur icon indicating copy to clipboard operation
connaisseur copied to clipboard

Feature request: Allow for adding custom labels to the deployment manifest of the helm chart

Open jimonthebarn opened this issue 1 year ago • 1 comments

We are currently facing the situation that we need to add additional custom labels to the deployment manifest created by the helm chart. This goes for the metadata/labels and the spec/template/metadata/labels section as we need those labels to be present on the pods created from the deployment as well.

I was thinking that one could enhance the helm.labels helper to also append a list of configurable labels and additionally add the aforementioned helper in the spec/template/metadata/labels section. If this sounds reasonable to you, I'm happy to provide an MR. What do you guys think.

Cheers, Ben

jimonthebarn avatar Feb 01 '24 14:02 jimonthebarn

@jimonthebarn Yes, absolutely. A MR is highly appreciated.

phbelitz avatar Feb 05 '24 08:02 phbelitz

I've created a pull request: https://github.com/sse-secure-systems/connaisseur/pull/1532

jimonthebarn avatar Mar 12 '24 15:03 jimonthebarn

This was already added, therefore closing the issue.

jimonthebarn avatar Apr 19 '24 09:04 jimonthebarn