Sebastian Schuberth

Results 1567 comments of Sebastian Schuberth

> Dismissing approval after July 14th ORT developer meeting discussion, additional changes to this PR are needed. While I couldn't join today's developer meeting, I believe we shouldn't try to...

> Do you know which these are @sschuberth ? I didn't yet have time to read through the [meeting minutes](https://github.com/oss-review-toolkit/ort/wiki/Developer-Meeting#2022-07-14), if that's what you mean. It seems like use-cases I've...

> Could somebody please explain if there are now further changes required by me or not? @porsche-rbieniek, let me take over this PR of yours, I'll get it merged. So...

Superseded by https://github.com/oss-review-toolkit/ort/pull/5680.

Hmm, I believe we should not start adding such kind of work-arounds on a per-package-manager basis. What do you think @mnonnenmacher, @MarcelBochtler?

> @sschuberth What do you mean by per-package-manager? I was mislead. At the first glance I somehow though the code would be Pub-specific, but it is not.

> Go mod currently doesn't provide license or copyright information for go modules hence ORT doesn't provide detected licenses for them. Before going deeper into the discussion, let's ensure we're...

> What's the source for license information that https://github.com/google/go-licenses uses, is it metadata or source code? So, after having a look it indeed seems as if https://github.com/google/go-licenses looks at license...

> So, shall we convert this ticket to 'adding licenseclassifier as scanner', or close this ticket and open-up a new one? I'd say we're blocked by https://github.com/google/licenseclassifier/issues/47 for now. Let's...

> What would be the process, running ORT analyze and then scan on the output of the analyze ? Yes, the input to the scanner is the output of the...