Sebastian Schuberth
Sebastian Schuberth
I see. Obviously, I didn't know about you specific requirement, nor that you were aware of the existing `maven-plugin-development` plugin. My main "pro" simply is: Reduce your own maintenance burden...
Apparently that works. I should also note that I'm not using `validate-wrappers: true` on `gradle/actions/setup-gradle`, but `gradle/actions/wrapper-validation` directly, if that makes a difference.
BTW, the file I'm using for testing can be cloned from https://github.com/fshost/node-dir/tree/a57c3b1b571dd91f464ae398090ba40f64ba38a2/test/fixtures/testdir5.
> I tried to clone the repo in order to reproduce this, and that wasn't even possible Are you on macOS maybe? > How did you manage to get those...
> > Can you provide a PR that will add the files to this repo? > > Here you go: [#391](https://github.com/gradle/actions/pull/391). Any update @bigdaz? Does that PR help you to...
> Can you please try running with `gradle/actions/wrapper-validation@main` and see if the issue is resolved for you? Still [seems to fail](https://github.com/oss-review-toolkit/ort-test-fork-node-dir/actions/runs/11817102968/job/32921816772#step:3:13). *Edit:* Ah, sorry, I was using `gradle/wrapper-validation-action@main`. Will try...
> Will try with `gradle/actions/wrapper-validation@main` again. That [works](https://github.com/oss-review-toolkit/ort-test-fork-node-dir/actions/runs/11817187578/job/32922069898#step:3:6)! And it even recognizes the wrapper that's committed to the same directory as the file with unmappable characters 👍🏻
> custom data per package Could you provide some concrete examples, and how that data would be used e.g. in rules or reporters?
Some comprehension examples regarding the example use-cases: > A user hosts source code for its dependencies on own infrastructure. Links to the source code shall be inserted into a NOTICE...
> > I assume that text is no static, otherwise it would be trivial. > > What would be a trivial solution for static text ? You could just add...