Sebastian Schuster

Results 130 comments of Sebastian Schuster

@laszlomiklosik If you are still interested in landing this, can you please sign off your commit (see https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s).

Hi @foch01 ! Thanks for your contribution. I checked your fix and it looks reasonable for me. However, the tests you added seem to be green with and without your...

@ravand1990 I am open to suggestions but I don't really see a more general approach. It currently looks like this has to be done for every individual field, at least...

@demetthyl Thanks for your contribution! You can skip tests for older versions like this: https://github.com/keycloak/terraform-provider-keycloak/blob/0afe0b2e1384a0f6f4a6ff43501689696548d7b6/provider/resource_keycloak_authentication_bindings_test.go#L129 Please also sign off your commit (`git commit -s --amend`).

@demetthyl We will probably remove testing for old Keycloak versions like 22 and 23 not too far away into the future. Maybe we just wait for this?

@demetthyl Unfortunately, I think this will still take some time. We first need to collect potential breaking changes to justify a new major release. We will probably have one or...

@johnbaro Thanks for your contribution! However, the go format check fails. Can you run a `make fmt` and commit the resulting changes?

@rhigdon Thanks for your contribution! Can you elaborate what problem you want to solve by adding the mutex to the client?

@rhigdon I will need a bit more time to test this so I just releases the new version without this to finally get it out of the door. I am...