ContextSearch-web-ext icon indicating copy to clipboard operation
ContextSearch-web-ext copied to clipboard

dock the highlight overview

Open hg42 opened this issue 6 years ago • 9 comments

The highlight overview also gets into trouble with elements at the right side, which for me is usually the CS button, but sometimes other elements, mostly buttons at the right side of a top menu bar. So this should be docked, too. I think this should always be docked. It's small...

hg42 avatar Jan 23 '19 10:01 hg42

I forgot to mention scrollbars or similar elements that are placed at the right side and impossible to be used with the overview. When it was only about the highlighting, I simply switched it off, but now the findbar already is a better search bar, so highlighting and the overview are kind of optional.

hg42 avatar Jan 23 '19 10:01 hg42

By 'docked' I assume you mean padding the page to prevent the nav div from covering page content like the panel option for the sidebar?

I'll give it a shot, but like the sidebar, it won't work everywhere. Many websites use fixed positioning for page elements and I haven't found a safe way to override those settings to prevent hiding page content. A few websites I've tested use styling that is particularly difficult to account for.

ssborbis avatar Jan 25 '19 21:01 ssborbis

By 'docked' I assume you mean padding the page to prevent the nav div from covering page content like the panel option for the sidebar?

yes, exactly

but like the sidebar, it won't work everywhere

Mozilla created a total mess with their decisions. So many workarounds necessary, it hurts my heart...and they don't listen (enough). And Google's decisions are even worse.

hg42 avatar Jan 30 '19 10:01 hg42

Because of Google's and Mozilla's restrictions on plugins, I sometimes wondered, if it would be possible to create a Browser in a browser. A bit like https://github.com/samlanning/leaf-browser but inside a page. My idea was to wrap the whole page in an iframe. But I fear it wouldn't work because of security restrictions of all kinds. You would at least need a way to detect clicks on links to update the tabs and address field.

hg42 avatar Jan 30 '19 10:01 hg42

Mozilla created a total mess with their decisions. So many workarounds necessary, it hurts my heart...and they don't listen (enough). And Google's decisions are even worse.**

Because of Google's and Mozilla's restrictions on plugins, I sometimes wondered, if it would be possible to create a Browser in a browser. A bit like https://github.com/samlanning/leaf-browser but inside a page. My idea was to wrap the whole page in an iframe. But I fear it wouldn't work because of security restrictions of all kinds. You would at least need a way to detect clicks on links to update the tabs and address field.

I was thinking something similar. The way things are now though I think it would be impossible with cross-origin security. A lot of addons could really benefit from having some browser space outside the webpage, if only on the edges (sidebar, top/bottom bar) and a modal / popup window. I know FF has a limited sidebar API now, but a cross-browser standard would be great. I really don't like having to inject all this code into every webpage but there's no other way.

ssborbis avatar Jan 30 '19 22:01 ssborbis

It's kind of funny that injecting code in web pages is considered more secure than creating gui elements outside a page. On the long run this will create a lot of totally unnecessary conflicts and risks. I think it's because more brain was applied to web page security than to gui security.

hg42 avatar Jan 31 '19 09:01 hg42

I'm not sure, if I should close such issues that are from me and (mostly) solved? (at least enough for my purposes)

hg42 avatar Oct 17 '19 19:10 hg42

This one feels like a wont fix issue. Leave it open, though. Trying to make the docking code work with most webpages is really difficult. Until I have better code for the sidebar, I won't even attempt to dock the overview.

ssborbis avatar Oct 17 '19 19:10 ssborbis

ok, seems I leave it to you to close "my" issues :-)

hg42 avatar Oct 17 '19 20:10 hg42