Sorin Sbarnea comments

Results 997 comments of


                                            Sorin Sbarnea

Help us improve README.md

Before improving this we need to make it work, see #22

`github.action_repository` and `github.action_ref` are empty in `run` for composite actions

Am I missing something or this means that is impossible to use a specific version of the action due to this bug?

`github.action_repository` and `github.action_ref` are empty in `run` for composite actions

We use dynamic versioning based on github tags, so basically is impossible for the code to discover its own version and tell user to upgrade if needed, code that we...

HackMD spell check language inconsistent with browser settings

TBH, I struggled to find where the spell checker is, it took me some time to find it as I was expecting to see it on the top toolbar not...

Setuptools does not pass config_settings through backend

@abravalheri Something is not right... ``` .package installdeps: setuptools >= 64.0.3, setuptools_scm[toml] >= 3.5.0, setuptools_scm_git_archive >= 1.0, wheel /Users/ssbarnea/c/os/tendo/.tox/.package/lib/python3.11/site-packages/setuptools/build_meta.py:307: SetuptoolsDeprecationWarning: The arguments ['--formats=gztar'] were given via `--global-option`. Please use `--build-option`...

`UserWarning: tag '0.0' no version found` in a fresh Git repo when `tag_regex` is defined

IMHO, I got this UserWarning which effectively translated to a full runtime error while having two tags, one matching the pattern and one not. IMHO, the whole point of this...

Request: adding type hints and py.typed to setuptools_scm

@RonnyPfannschmidt Any chance to resume on that? Even partial types could help, we don't need 100% from start.

setuptools incorrectly picks tag between multiple lightweight tags (github release)

I do still have other issues with GHA and I am aware that this issue is more on github-garden than setuptools-scm, but lets keep it open for a while until...

setuptools incorrectly picks tag between multiple lightweight tags (github release)

It seems that every other months I accidentally make a full release because the I add a tag like `v1.0.0a0` and setuptools-scm ends-up releasing `1.0.0`. In fact i would find...

setuptools incorrectly picks tag between multiple lightweight tags (github release)

Few years later and I endup at the same bug, this time with a little more interesting twist. I have two tags on head `v1.2.3` and `v1`, the second one...