Satoru SATOH
Satoru SATOH
> * [ ] Fix/improve yamllint.rules.get called many times: https://github.com/adrienverge/yamllint/pull/315/files#diff-85022b669c894366f26191332b108dd5R69 > > * I pushed another experimental commit [3503eb0](https://github.com/adrienverge/yamllint/commit/3503eb0ca36117e39f455f8502e0da988e69171e) for this. It introduces another runtime dependency to functools32 for python...
@adrienverge Are there any issues left behind or I forgot? If it's OK, I'll squash all of them into a few commits to prepare you can easily merge them.
> I don't know about issues, I still need to take time to test and review. But you can squash +1 Thanks! I squashed them into 3 commits.
> Hello @ssato, thanks for the work! Here is a first review. Thanks for the comments! @adrienverge. Before going into details, I think that it should be better to have...
> 1. > I think that it should be better to have a standalone git repo separate from yamllint's repo as a rules plugin reference implementation fully tested, git-{clone,fork}-able, and...
Hello @adrienverge, > Hello @ssato, > > I think the main code (in `yamllint/`) is ready. Thanks a lot! > However I was talking about testing _the yamllint code that...
> Please don't change `tests/test_spec_examples.py` because it's not meant for that. I think that change should not change its original behavior. And I did so to achieve the following. I...
> I'm talking about removing tests from `tests/yamllint_plugin_example/tests/` (or leaving just very basic ones, just to encourage developers to write tests for their plugins) and moving all these tests to...
Very sorry to left it and gave no response to you for a long time. A lot happened in my personal life and could not work on this. Anyway, I...
Excuse me. I made a mistake that filters are always applied with '|' operator, AFAIK. So that it may be enough to add notes about associativity and precedence between operators.