Sasha Rush

Sorry I'm still having trouble understanding. I'm really trying to figure it out, but I need a more clear example. 1) The 0 word is a real word in the...

I still do not understand exactly where you think the problem is. Do you think the problem is with the score function? We could try use torch.where instead of torch.mul...

Thanks this is a good repro case. I see the issue, but I do not yet have a good fix. Can't tell if it is an inherent issue in the...

Oh, Unfortunately alignment crf only runs on gpu, so the tests don't catch this. Are you using it? Wondering if I should just remove it until I figure out a...

Yes, they should run on GPU, but they don't run automatically. If you want to fix them and check that they pass that would be great. Otherwise, I'll take a...

Do you have a paper reference? I don't know much about 2d parsing, but we could add something.

neat, I'll take a look. I think the bottom paper is just a standard 1d CRF, but the top paper looks like it has special 2d grammars.

Yes! It works and is heavily tested. We should make it default. It just requires the GPU kernels in genbmm be installed.

yes, that would be great. You can do it for max too.

Sorry :( I didn't save them. They were a bit rough anyway, and didn't realize there was demand. I'll upload some to youtube, and keep doing some others. Any topics...