rust-disruptor icon indicating copy to clipboard operation
rust-disruptor copied to clipboard

Get the project working on current Rust

Open marshallpierce opened this issue 7 years ago • 3 comments

I tried to follow the original intent of the code while updating it to satisfy the current language rules (mostly syntax fixes and trait bounds).

Other stuff:

  • Remove custom build scripts and just use Cargo. cargo watch can be used to provide auto-rebuild.sh's functionality if desired.
  • Moved #[bench] functions to a file in benches since that allows cargo bench to work
  • Moved unicast test to examples, runnable with cargo run --example unicast_throughput_test

marshallpierce avatar Feb 07 '18 16:02 marshallpierce

Oh wow, I'm so sorry about this. I have a branch I had worked on on and off to port things to modern Rust that I really wish I'd pushed out before now. It's been sitting on my laptop for.. apparently a year now since I got it working. The perfectionist in me was hoping to bring the SpinWaitStrategy performance back up to where it originally was, because I'd noticed a slight hit since porting it, but that's really no excuse for not pushing earlier. I've pushed it out to master, would you mind rebasing your work on top of it? I realize this is probably the most discouraging response you could get after working so hard to port it on your own, and I hope it doesn't completely ruin the fun for you.

If you prefer, I can try to find time on a weekend to rebase your changes myself, just let me know. Again, I'm very sorry about this, I deeply regret not pushing my changes out sooner.

sruggier avatar Feb 07 '18 16:02 sruggier

Heh, that's okay. I'll check it out in the next day or two.

marshallpierce avatar Feb 07 '18 17:02 marshallpierce

Whew, OK, thanks. Likewise for your changes, I'll take a look sometime this weekend or the next. It's not fresh enough in my mind to answer your questions now, but you should find answers in the changes I pushed out, except for your comment about false-sharing avoidance, which I'll have to confirm.

sruggier avatar Feb 07 '18 17:02 sruggier