srsRAN_4G icon indicating copy to clipboard operation
srsRAN_4G copied to clipboard

probably mispelled property in pcap

Open tiamilani opened this issue 2 years ago • 2 comments

In the pcap section, the documentation talks about the mac_enable property. This property is not in the actual properties of the [pcap] section. I thought it would be more probable to forget about the documentation property rather than the actual property name. For this reason, I have changed the documentation from mac_enable to enable. I have not executed any test on the change.

In the enb_cfg_parser.cc I have not found any reference to mac_enable but only to enable.

tiamilani avatar Aug 09 '22 14:08 tiamilani

 1288看

---Original--- From: @.> Date: Tue, Aug 9, 2022 22:10 PM To: @.>; Cc: @.***>; Subject: [srsran/srsRAN] probably mispelled property in pcap (PR #954)

In the pcap section, the documentation talks about the mac_enable property. This property is not in the actual properties of the [pcap] section. I thought it would be more probable to forget about the documentation property rather than the actual property name. For this reason, I have changed the documentation from mac_enable to enable. I have not executed any test on the change.

In the enb_cfg_parser.cc I have not found any reference to mac_enable but only to enable.

You can view, comment on, or merge this pull request online at:

  https://github.com/srsran/srsRAN/pull/954

Commit Summary

e26960b probably mispelled property in pcap
File Changes

(1 file)

 M     srsenb/enb.conf.example     (2)     

Patch Links:

https://github.com/srsran/srsRAN/pull/954.patch
https://github.com/srsran/srsRAN/pull/954.diff
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

smhilu avatar Aug 11 '22 01:08 smhilu

144点嗄1

---Original--- From: @.> Date: Tue, Aug 9, 2022 22:10 PM To: @.>; Cc: @.***>; Subject: [srsran/srsRAN] probably mispelled property in pcap (PR #954)

In the pcap section, the documentation talks about the mac_enable property. This property is not in the actual properties of the [pcap] section. I thought it would be more probable to forget about the documentation property rather than the actual property name. For this reason, I have changed the documentation from mac_enable to enable. I have not executed any test on the change.

In the enb_cfg_parser.cc I have not found any reference to mac_enable but only to enable.

You can view, comment on, or merge this pull request online at:

  https://github.com/srsran/srsRAN/pull/954

Commit Summary

e26960b probably mispelled property in pcap
File Changes

(1 file)

 M     srsenb/enb.conf.example     (2)     

Patch Links:

https://github.com/srsran/srsRAN/pull/954.patch
https://github.com/srsran/srsRAN/pull/954.diff
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

smhilu avatar Aug 11 '22 01:08 smhilu

Thanks for that. Merging that in for the next release.

andrepuschmann avatar Nov 02 '22 12:11 andrepuschmann