srsRAN_4G icon indicating copy to clipboard operation
srsRAN_4G copied to clipboard

Add subnet mask of interface for the SGi connection

Open matan1008 opened this issue 4 years ago • 7 comments

Hey! This change will allow allocating more than 254 addresses for UEs. I am pretty terrified that I missed something, so I would like your close inspection and your professional opinion.

Thanks for dedicating time!

matan1008 avatar Apr 17 '21 20:04 matan1008

Thanks for the contribution @matan1008 . We'll review it shortly.

andrepuschmann avatar Apr 22 '21 15:04 andrepuschmann

Is there anything I can do to help with the PR?

matan1008 avatar Jul 23 '21 06:07 matan1008

Could you please check if this PR is still relevant? Thanks

andrepuschmann avatar Oct 29 '21 08:10 andrepuschmann

Still relevant :smile: Would you like me to rebase it against the current master?

matan1008 avatar Oct 29 '21 09:10 matan1008

Still relevant smile Would you like me to rebase it against the current master?

Thanks for the quick response. Do you mind rebasing PR on current master.

andrepuschmann avatar Oct 29 '21 09:10 andrepuschmann

I think it's fine, but IP network programming is not my area of expertise so please review it carefully :bow:

matan1008 avatar Oct 29 '21 11:10 matan1008

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 08 '22 08:11 CLAassistant