gradle-node-plugin icon indicating copy to clipboard operation
gradle-node-plugin copied to clipboard
verified publisher icon srs

NpmInstallTask/YarnInstallTask declare inputs/outputs twice.

Open deepy opened this issue 6 years ago • 1 comments

We found this while backporting functionality from here. https://github.com/node-gradle/gradle-node-plugin/issues/20

inputs/outputs are declared twice and only one is optional. Line 25 should have had a .optional() at the end to match.

https://github.com/srs/gradle-node-plugin/blob/3052d9bd2db5c8fbe4bc3fd0306fcb8a805c0577/src/main/groovy/com/moowork/gradle/node/npm/NpmInstallTask.groovy#L23-L27

https://github.com/srs/gradle-node-plugin/blob/3052d9bd2db5c8fbe4bc3fd0306fcb8a805c0577/src/main/groovy/com/moowork/gradle/node/npm/NpmInstallTask.groovy#L39-L42

deepy avatar Jun 19 '19 14:06 deepy

Also, in the case of npm install the package-lock.json should probably be an output https://docs.npmjs.com/files/package-lock.json

deepy avatar Jun 19 '19 15:06 deepy