gradle-grunt-plugin icon indicating copy to clipboard operation
gradle-grunt-plugin copied to clipboard

Install grunt and grunt-cli versions as specified in the npm package.json

Open tjsingleton opened this issue 10 years ago • 10 comments

Given a package.json exists, when the installGrunt task is executed then install the versions specified in the package.json.

tjsingleton avatar Apr 05 '16 01:04 tjsingleton

@srs Our builds started failing today because of an issue with the version of grunt-cli being used. I was about to work around it by doing this: installGrunt.setArgs( ['install', '[email protected]', 'grunt@~0.4.2'] ).

I'd be happy to implement support for both manually configuring the versions, as well as loading it from a package.json if it exists and is applicable. Would you be open to a PR?

tjsingleton avatar Apr 05 '16 01:04 tjsingleton

Hi.

Always open for PR's. tir. 5. apr. 2016 kl. 03.53 skrev TJ Singleton [email protected]:

@srs https://github.com/srs Our builds started failing today because of an issue with the version of grunt-cli being used. I was about to work around it by doing this: installGrunt.setArgs( ['install', '[email protected]', 'grunt@~0.4.2'] ).

I'd be happy to implement support for both manually configuring the versions, as well as loading it from a package.json if it exists and is applicable. Would you be open to a PR?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/srs/gradle-grunt-plugin/issues/32#issuecomment-205592197

srs avatar Apr 05 '16 04:04 srs

Yes, I can confirm this issue. Also started to happen here as the grunt-cli always is installed in the most recent version and that seems to have some issues for whatever reason.

tspaeth avatar Apr 05 '16 11:04 tspaeth

Issue is buried down in the grunt update to 1.0.0 - https://github.com/gruntjs/grunt/issues/1499 & https://github.com/gruntjs/grunt/issues/1491

tspaeth avatar Apr 05 '16 11:04 tspaeth

I would like to see this implemented also, but I think this is the same request as issue #19 here - https://github.com/srs/gradle-grunt-plugin/issues/19

Neil201 avatar Apr 06 '16 10:04 Neil201

I read #19 as setting the gradle project version.

tjsingleton avatar Apr 07 '16 12:04 tjsingleton

yeah sorry your right , my bad.

Neil201 avatar Apr 07 '16 20:04 Neil201

+1

stevematyas avatar Apr 15 '16 14:04 stevematyas

Workaround for me:

  • Do not use this plugin's gruntInstall task
  • Instead
    • Add grunt-cli to package.json
    • Instead use npmInstall of the gradle npm plugin

eekboom avatar Apr 25 '16 13:04 eekboom

Anyone has a pull request for this?

srs avatar Jun 27 '16 10:06 srs