Steven Rotondo

Results 19 comments of Steven Rotondo

@datapythonista I've added the test and the release note to this code, is there anything else you would like me to do?

@datapythonista I believe I have made the appropriate changes. Is there anything else?

@datapythonista I believe that I have made all the changes you have requested, including simplifying the tests. Is there anything else you would like me to do?

@datapythonista I've split up the test into multiple pieces like you asked.

> But looks like you're somehow reimplementing the tests in [here](https://github.com/pandas-dev/pandas/blob/main/pandas/tests/tools/test_to_datetime.py#L949), no? Would be good to start by adding the exact case or test that your fix addresses, which is...

@datapythonista The true failing case is that when 2 valid dates with different formats were passed in using the `errors = "coerce"` option and `infer_datetime_format = True`, `to_datetime` would return...

The difference arises due to the fact that in the `offset.pyx` file, where the addition is done, the scalar case uses a loop with a variable `n` in the `RelativeDeltaOffset`...

Other similar instances of this operation in other related classes to `DateOffset` use the method where they calculate the combined offset of all `n` multiplications and move the date as...

This function that this change is in doesn't care about the error variable, shown by the fact that there is no argument for the errors in the code. This function...