rpmfile icon indicating copy to clipboard operation
rpmfile copied to clipboard

RPM header tag "copyright" should be "license"

Open tpodowd opened this issue 2 years ago • 2 comments
trafficstars

According to https://rpm-software-management.github.io/rpm/manual/tags.html , tag 1014 should called license and not copyright.

Here is one example: https://github.com/srossross/rpmfile/blob/185ac915eb701d15bcb2338ad63ca81366f4ce16/rpmfile/headers.py#L41 https://github.com/srossross/rpmfile/blob/185ac915eb701d15bcb2338ad63ca81366f4ce16/rpmfile/rpmdefs.py#L59 https://github.com/srossross/rpmfile/blob/185ac915eb701d15bcb2338ad63ca81366f4ce16/rpmfile/rpmdefs.py#L69

In the main cli command you are already changing the header title to License... https://github.com/srossross/rpmfile/blob/185ac915eb701d15bcb2338ad63ca81366f4ce16/rpmfile/cli.py#L79-L87

The rpm command itself also does not find a copyright header tag.

$ rpm -q --qf "%{LICENSE}\n" bash
GPLv3+
$ rpm -q --qf "%{COPYRIGHT}\n" bash
error: incorrect format: unknown tag: "COPYRIGHT"

tpodowd avatar Oct 09 '23 05:10 tpodowd

Are you looking for an alias for the variable or a rename?

johnandersen777 avatar Nov 09 '23 22:11 johnandersen777

Hi @pdxjohnny - Thanks for your reply. I would think an alias makes more sense at this stage as folks may already be using copyright. Perhaps, change the the field to license and then make copyright the alias.

tpodowd avatar Nov 09 '23 23:11 tpodowd