KnightOnline icon indicating copy to clipboard operation
KnightOnline copied to clipboard

Anvil CUIItemUpgrade implemented

Open Mervandeli opened this issue 4 months ago • 5 comments

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

What is the current behaviour?

-Item Upgrade not implemented

What is the new behaviour?

-The CUIItemUpgrade class has been implemented, and the UI behaviors work the same as in the original 1298 Client. Items can be upgraded correctly.

Why and how did I change this?

-The items in the ItemUpgrade window are copied from the inventory and backed up. When the window is closed or the Cancel button is pressed, the items are restored from the backup. A backup is used to prevent errors when switching between Inventory and ItemUpgrade. If the upgrade process succeeds or fails, the backup is updated accordingly.

Checklist

  • [x] I have performed a self-review of my own code.
  • [x] Where applicable, I have checked to make sure that this doesn't introduce incompatible behaviour with the official 1.298 server (e.g. unofficial opcodes or behavioural differences).
  • [x] I have checked to make sure that this change does not already exist in the codebase in some fashion (e.g. UI already implemented under a different name).

Mervandeli avatar Aug 13 '25 15:08 Mervandeli

Scroll check and other reviews solved.

Mervandeli avatar Aug 15 '25 01:08 Mervandeli

@Mervandeli There's nothing to review, no changes have been pushed yet

twostars avatar Aug 20 '25 17:08 twostars

@Mervandeli There's nothing to review, no changes have been pushed yet

Sorry,I misclicked.I will send it by Monday.

Mervandeli avatar Aug 20 '25 22:08 Mervandeli

@twostars Can you check again. The N3uibase class has been used. Items are copied instead of moved. Fixed the issue with transferring all icons for countable items. Some member methods have been removed. Used N3_VERIFY_UI_COMPONENT and moved it to load Almost all review comments fixed

Mervandeli avatar Sep 27 '25 16:09 Mervandeli

Please fix the build issues first, and then I'll re-review it.

twostars avatar Sep 27 '25 23:09 twostars