srl
srl
I think this needs to pull in the merged changes?
Closing in favour of #1069
A bit of a known issue. Result from being able to handle "srp" properly: https://github.com/genshinsim/gcsim/blob/26e4bbf8aa0974152a316e2ea1dfe837eac67c53/pkg/core/combat/attack.go#L69-L83 Here I had to delay the damage and attachment of any aura until the end...
``` nahida char lvl=90/90 cons=2 talent=9,10,10; nahida add weapon="pamber" refine=5 lvl=90/90; nahida add set="deepwoodmemories" count=4; nahida add stats def%=0.10930001 def=74.07001 hp=5497.0100999999995 atk=416.040009 atk%=0.040800004 er=0.27850002500000004 em=228.460003 cr=0.559900009 cd=0.65270003 dendro%=0.466; zhongli char...
this should be doable now with the new stats framework, maybe.
on hold for now because it looks like this might actually be a performance decrease for wasm. needs more testing also need to fix env scoping which is causing issues...
no longer relevant. the energy warning on ui should be sufficient
Closing for same reason as https://github.com/genshinsim/gcsim/issues/561#issuecomment-1622012715
Closing this. The design here is basically stale. Can open new issue for any future improvements.
no longer relevant