srl

Results 50 comments of srl

> `AnimationCancelDelay` function does not get called every frame though. You can see here: https://github.com/genshinsim/gcsim/blob/2fa6d62f942589b81606e5107be8cae5943df947/pkg/simulation/run.go#L80-L84 If delay is valid, it sets s.skip and on the next frame if s.skip >...

can't we just log this instead? like log some kind of statistics on number of frames the sim is stuck waiting for energy for each run, and then present that...

> https://docs.google.com/spreadsheets/d/1BdWsPgnZFJ2xFmKgYevvBXYQeDqOLaPpL_VsFzjjiiI/edit?usp=sharing xingqiu frames sheet. currently only 1 trial each (in future counts I will do 3) and not all combos tested, let me know how much more needs to...

#447 updates noelle but missing: attack -> charge attack -> walk charge -> x

all done (for now until tomorrow) :) this is also tracked in docs as well

@HanSeoulOh this is not done btw

So what I had in mind was probaby slightly different. Rather than registering a new structure, I was thinking more of something like the following: ```go type StatCollector interface {...

> (From a discussion on discord) > > thinking about the stat collection a bit more, here is what I'd probably lean towards doing (granted I have not familiarized myself...

hey there. thanks for submitting this. there does seem to be some interest in this option. however the only issue is i'm not sure the current animations framework is stable...