Steven R. Loomis
Steven R. Loomis
@catamorphism all LGTM! - probably want to squash it per ICU prefs - https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/icu/2980 (the 'Details' under the single-commit check) will do it for you - @echeran are you driving...
- [x] TODO lint
@not-an-aardvark right now the implementation is that it checks whether it's a valid URL, otherwise assumes it's a sha. I think that makes sense, however, I wasn't sure what the...
@caridy thanks! Can you put in the full data with: - download http://sourceforge.net/projects/icu/files/ICU4C/54.1/icu4c-54_1-src.zip/download - find the file `source/data/in/icudt54l.dat` in that archive (23Mb) - run `node` with either variable `ICU_DATA_DIR=…` or...
@caridy try not using the `~` but a full path. The crash is a v8 bug with an issue assigned to me to workaround/float a patch [here](https://github.com/joyent/node/issues/9361). In later v8s...
@caridy I'm not sure what the regexp or the `nu-native` tests are trying to do, but the AED bug, if the error message is correct, is an actual bug.
@caridy sounds good. Would be a great thing to run in CI!
- Probably separate docs for bumps and tests - compare with docs for upgrading libuv, openssl, etc - related to 'floating patch' situation
- Double Width- Unicode East Asian Width property distinguishes `a` vs `ａ` etc. Also affected by combining.
Thanks!