containerlab icon indicating copy to clipboard operation
containerlab copied to clipboard

Download License + scp and ftp (also e.g. for startup-config)

Open steiler opened this issue 1 year ago • 5 comments

This PR makes license files downloadable and embeddable. It further also implements scp and ftp as download protocols for also als the existing downloadable content (e.g. startup-config).

steiler avatar May 31 '23 12:05 steiler

implementing #1377

steiler avatar May 31 '23 13:05 steiler

Is there any timeline when we could expect this PR to be merged? Is there anything needed to be tested/checked to get this? For Nokia internal usage this would further simplify labbing!

mabra94 avatar Nov 07 '23 15:11 mabra94

Let me base it on the actual master branch to resolve merge conflicts then @hellt can probably get to it. ;-)

steiler avatar Nov 07 '23 16:11 steiler

Do we want to run the tests for the downloads as seperate suite or also make it part of smoke tests? I feel like it is wuite some heavily lifting for whats the checked in the end.

steiler avatar Nov 13 '23 11:11 steiler

Codecov Report

Attention: 202 lines in your changes are missing coverage. Please review.

Comparison is base (404e6f9) 51.78% compared to head (93bf471) 51.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
- Coverage   51.78%   51.19%   -0.60%     
==========================================
  Files         148      148              
  Lines       14548    14777     +229     
==========================================
+ Hits         7534     7565      +31     
- Misses       6180     6374     +194     
- Partials      834      838       +4     
Files Coverage Δ
clab/clab.go 76.85% <100.00%> (+0.17%) :arrow_up:
types/topo_paths.go 68.54% <0.00%> (-1.13%) :arrow_down:
clab/config.go 65.94% <66.66%> (-0.64%) :arrow_down:
utils/file.go 35.07% <8.17%> (-19.85%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Jan 23 '24 14:01 codecov[bot]