containerlab icon indicating copy to clipboard operation
containerlab copied to clipboard

Store information about NodeGeneration in registry.

Open steiler opened this issue 1 year ago • 3 comments

So far generate.go contained two lists indenpendent from the nodes, that would describe nodes that (1) can be generated and (b) what the interface naming convention would be for the node kind. This will introduce seperate fields in the NodeRegistry for this information, such that the information for this sort of node generation can be defined as part of the node definition

steiler avatar Apr 28 '23 10:04 steiler

I have, by the way, taken over the actual view on which nodes are eligable for topology generation. But I have the feeling, that this list could be extended, Maybe take another look at it @hellt

steiler avatar Apr 28 '23 10:04 steiler

takes also already vr-vsrx into account.

steiler avatar May 02 '23 06:05 steiler

Codecov Report

Merging #1347 (dc33e4a) into main (26b2ee4) will increase coverage by 0.19%. The diff coverage is 86.53%.

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   20.86%   21.05%   +0.19%     
==========================================
  Files          57       57              
  Lines        6275     6280       +5     
==========================================
+ Hits         1309     1322      +13     
+ Misses       4845     4837       -8     
  Partials      121      121              
Impacted Files Coverage Δ
clab/config/utils.go 42.43% <0.00%> (ø)
cmd/generate.go 37.15% <68.42%> (+5.23%) :arrow_up:
clab/clab.go 31.02% <100.00%> (ø)
clab/register.go 100.00% <100.00%> (ø)

codecov[bot] avatar May 02 '23 06:05 codecov[bot]