Sebastian Rittau comments

Results 518 comments of


                                            Sebastian Rittau

Use Callable[..., Any] instead of Callable[..., object] in unittest

What makes unittest special here?

Use Callable[..., Any] instead of Callable[..., object] in unittest

I'm still opposed to this. At this point I don't think we should regress our stubs due to type checker bugs that can be worked around with "# type: ignore"....

Use Callable[..., Any] instead of Callable[..., object] in unittest

I would be more open to this if we had some process that would ensure that we restore the "correct" stubs once the bug is fixed in mypy. And by...

Use Callable[..., Any] instead of Callable[..., object] in unittest

It's not a functional regression in this particular case, but stylistic one. We invested effort in streamlining callable annotations to use `object` return types, instead of `Any`. Changing it back...

Use Callable[..., Any] instead of Callable[..., object] in unittest

One idea I have is to merge this and just create the reverting PR already, marking it as "deferred". This would mean that there's less chance we forget if mypy...

Is there a good reason why `Mapping.contains` expects `object`, but `Mapping.get` expects a strict type?

I definitely see the logic in that, but I also expect that a change like this would break quite a lot. An exploratory PR to judge the impact would be...

Add third-party lief stubs

Ah I see. The original commit indeed has lots of problems. Normally that script generates acceptable stubs, but not in this case, unfortunately. So please ignore my comment above. But...

Decouple collections.abc types from typing aliases

I'm fine with everything that brings typeshed closer to the implementation. But please note that generics are expected to work with `collections.abc` with all Python versions in stubs or when...

[email protected] regression: Argument 1 to "get" of "Mapping" has incompatible type

The stricter typing for `get()` will catch potential type problems. While your example will work at runtime, it indicates a likely bug as `None` is not a valid key. I...

[email protected] regression: Argument 1 to "get" of "Mapping" has incompatible type

I don't think that this is the way forward. Type checkers are supposed to check that the types are correct after all. If you don't know types or are not...