Sebastian Rittau
Sebastian Rittau
While I'm in favor of this PR – even if it would cause a huge amount of (easy to fix) warnings – I suggest we wait for the release of...
Personally, I prefer to use `typing` in examples when a feature has been released in a stable version of Python, as that is the canonical location. Users should be smart...
I'm sorry for the long delay before we managed to review and merge it.
I'm not a huge fan of composing protocols by sub-classing them like this. For these simple protocols, I find them easier to read if they just copy the method definitions....
Possibly fixed by #12181.
Let's judge the impact of removing this.
Originally added in #3483, in which the author was already wondering whether to put it on the sub-classes. But the lazy reviewer didn't look closer.
I'm not a fan of this change. This would decrease the type safety for the common case. For example, `TestCase.assertGreater` really wants an object that returns a `bool` and not...
I'm still opposed to this. Overloading the comparison operators to return something other than `bool` is unexpected and using `# type: ignore` to make this explicit is acceptable.
The primer diff will be interesting, once we merge #12939.