Sebastian Rittau
Sebastian Rittau
It seems that mypy has problems with the first overload, but I'm not sure why. Everything seems correct to me and pyright seems to agree. For now, I would suggest...
I've marked this PR as deferred for now due to the mypy bug.
The [mypy primer output above](https://github.com/python/typeshed/pull/11646#issuecomment-2016473736) shows the real-world impact this change has on a selected number of packages. Each green line is a new mypy warning. As you can see,...
At the moment, this doesn't look promising. Unless someone has another good idea, I suggest we close this PR – at least for now.
I see that it's already marked as deferred. I've also marked it as draft, just so it doesn't stand out as much in the open PRs list.
Diff: https://github.com/networkx/networkx/compare/networkx-3.2.1...networkx-3.3
The pyright tests are failing, since `tablib` has no stubs or type annotations yet. So instead of trying to import it, in typeshed we usually just type alias any imported...
> Interesting `pytype` error.. Considering that `Library.simple_tag` doesn't seem to change the signature, it's probably easiest to just leave it off. We also need to add django-stubs to the stub...
Thanks for opening the discussion! I've marked this PR as "deferred" for now.
@erictraut: I'm unsure why pyright fails the test case as written: https://github.com/python/typeshed/actions/runs/8613668710/job/23605460935?pr=11632 ```python custom_c = cast("Counter[str, Foo]", Counter()) # [...] custom_c["a"] += 42 # type: ignore ``` pyright claims that...