qlZipInfo icon indicating copy to clipboard operation
qlZipInfo copied to clipboard

Modernized Preview

Open mbrotz opened this issue 1 year ago • 11 comments

These changes improve the layout and appearance of the generated preview to more closely match the Finder.

  • Both light and dark themes are supported.
  • Colors more closely match the Finder.
  • New svg icons for files and folders.
  • A new column shows file permissions.
  • The preview window is larger.

mbrotz avatar May 03 '24 07:05 mbrotz

Note

Only the preview for archive files supported by libarchive is modified. The previews generated for binhex and .sit files remain unchanged. However, since i don't have compatible archives i currently cannot test them.

mbrotz avatar May 03 '24 07:05 mbrotz

@mbrotz not sure when this one is getting merged but how easy is this to build myself? Or to provide a build version of your improvements? thanks

koenvb avatar May 09 '24 15:05 koenvb

@koenvb You can simply open the project in xcode and hit the run button to build it.

By the way, i talked to @srirangav via email already. He said he would be happy to merge the changes.

I also attached two screenshots here.

Manuel

image

image

mbrotz avatar May 09 '24 15:05 mbrotz

Do i have to resolve the conflicts?

mbrotz avatar Jul 12 '24 06:07 mbrotz

Do i have to resolve the conflicts?

Conflicts are very minimal and not worth the delay. I made PR with resolved conflicts for your repo, and you can update this PR.

romanr avatar Sep 12 '24 08:09 romanr

Any chance this is gonna be merged anytime soon? :)

mbrotz avatar Oct 25 '24 12:10 mbrotz

Hi, I installed qlZipInfo following the instructions (placed in ~/Library/QuickLook, set permissions, and reloaded Quick Look), but it’s not working on macOS Sequoia 15.1 with an M1 Pro chip. Quick Look does not preview ZIP files. Any suggestions to troubleshoot this?

bigplayer-ai avatar Nov 20 '24 07:11 bigplayer-ai

Hi, I installed qlZipInfo following the instructions (placed in ~/Library/QuickLook, set permissions, and reloaded Quick Look), but it’s not working on macOS Sequoia 15.1 with an M1 Pro chip. Quick Look does not preview ZIP files. Any suggestions to troubleshoot this?

Apple has removed support for QuickLook generators and has moved to a different method in MacOS Sequoia (see: https://eclecticlight.co/2024/10/31/how-sequoia-has-changed-quicklook-and-its-thumbnails/). I don't have a good example of how to re-implement this using Apple's new method. If I can find a good example, perhaps I will be able to rewrite this.

Sorry for any inconvenience.

-ranga

srirangav avatar Nov 27 '24 20:11 srirangav

Thanks for the update and the link @srirangav !

dserodio avatar Nov 27 '24 21:11 dserodio

Any chance this is gonna be merged anytime soon? :)

Hi,

I merged some of the proposed changes into the latest version. I will merge some additional changes into the next version.

FYI, I am not sure what to do about the SVG icons because they seem to make things slower on large files on my older Macs.

Thanks,

-ranga

srirangav avatar Nov 27 '24 21:11 srirangav

Any chance this is gonna be merged anytime soon? :)

Hi,

I merged some of the proposed changes into the latest version. I will merge some additional changes into the next version.

FYI, I am not sure what to do about the SVG icons because they seem to make things slower on large files on my older Macs.

Thanks,

-ranga

Hi

Great to hear! :)

Yes, i can imagine that the svg icons might cause a slowdown on large files since the svg code for every icon has to be inserted explicitly for every item. A possibility would be to simply not display them if the number of items is large, for example more than 1000 or so. I wasn't able to embed the files into the executable and then refer to them from within the generated preview. I just don't know how to reference them, if it is even possible. If the icons could be embedded into the executable we could also pre render them as png files. That might mitigate the performance issues...

Manuel

mbrotz avatar Dec 03 '24 11:12 mbrotz

Hi

If you need me to do anything here, you have to give me a bit of help. I don't have much experience with colaborating on github...

Manuel

mbrotz avatar Apr 10 '25 05:04 mbrotz

Hi, I installed qlZipInfo following the instructions (placed in ~/Library/QuickLook, set permissions, and reloaded Quick Look), but it’s not working on macOS Sequoia 15.1 with an M1 Pro chip. Quick Look does not preview ZIP files. Any suggestions to troubleshoot this?

Apple has removed support for QuickLook generators and has moved to a different method in MacOS Sequoia (see: https://eclecticlight.co/2024/10/31/how-sequoia-has-changed-quicklook-and-its-thumbnails/). I don't have a good example of how to re-implement this using Apple's new method. If I can find a good example, perhaps I will be able to rewrite this.

Sorry for any inconvenience.

-ranga

Is it possible to integrate this into Keka or another open-source macOS file archiver, now that the standard method no longer works in macOS Sequoia 15.4?

bigplayer-ai avatar Apr 10 '25 07:04 bigplayer-ai