Github-Profile-README icon indicating copy to clipboard operation
Github-Profile-README copied to clipboard

Name not matching with the README markdown

Open srinibasbiswal opened this issue 5 years ago • 8 comments

Sometimes the name is not matching with the markdown README. It is getting resolved after hard reloading. But sometimes it takes up to 2-3 hard reloads to fix.

srinibasbiswal avatar Oct 01 '20 05:10 srinibasbiswal

Can I take this?

gioboa avatar Oct 01 '20 05:10 gioboa

sure @gioboa

srinibasbiswal avatar Oct 01 '20 06:10 srinibasbiswal

Hi @gioboa , I have merged the PR #16 , but the issue is still present. So keeping this issue open. Thanks for the cache suggestion.

srinibasbiswal avatar Oct 01 '20 20:10 srinibasbiswal

One thing I noticed, the issue comes after deployment and after hard-refreshing, the issue doesn't come anymore. Again when deployment happens, the issue comes again. Deployment Structure: After every commit, the project gets builds and the build folder gets deployed to firebase hosting. I am guessing either its a deployment issue or a cache issue.

srinibasbiswal avatar Oct 01 '20 20:10 srinibasbiswal

Maybe this answer fit this issue

gioboa avatar Oct 01 '20 20:10 gioboa

Thanks, @gioboa for the suggestion. I have implemented that. This time after the deployment, I didn't do any hard reloads and the data is loading as expected. Still, I will wait for 1 more day and observe if it's really solved. Really appreciate your help.

srinibasbiswal avatar Oct 01 '20 21:10 srinibasbiswal

Glad to help you 🚀 💪

gioboa avatar Oct 01 '20 21:10 gioboa

The issue is still there. I tried triaging the issue. These are my observations :

  • Only data of consecutive files are exchanged.
  • Currently, onLoad all the markdown files are read using Promise.all().
  • It is returning only the data of the files, so another list is maintained to keep the record of the sequence in which the file names were read.
  • There is a chance that the sequence and the data that is returned is not matching.
  • Possible file whee=re the issue is occurring : src/containers/WallContainer.js

This issue will be tracked on another branch. issue#11

srinibasbiswal avatar Oct 02 '20 22:10 srinibasbiswal