Srikanth Chekuri

wsclient: Unexpected error while receiving:read ... use of closed network connection

1

When ws client is stopped, it closes the connection here https://github.com/open-telemetry/opamp-go/blob/06011e4b754e9d41cbba7b5c166c6d2eec7b82d8/client/wsclient.go#L84-L90 and cancels the context https://github.com/open-telemetry/opamp-go/blob/06011e4b754e9d41cbba7b5c166c6d2eec7b82d8/client/internal/clientcommon.go#L151-L156 And the [ReceiverLoop](https://github.com/open-telemetry/opamp-go/blob/06011e4b754e9d41cbba7b5c166c6d2eec7b82d8/client/internal/wsreceiver.go#L45) tries to read a message from the closed connection resulting in...

`rcvCommand` should send update to Server on err

5

The `rcvCommand` in receivedProcessor ignores the returned error from the callback `OnCommand`. When the error is non-nil it should be reported to Server with `AgentHealth.healhy=false` along with `lastError` (@tigrannajaryan, I...

Run https://github.com/open-telemetry/opamp-go/actions/runs/5402880306/jobs/9814852991?pr=180

Update AgentHealth when OnCommand returns error

1

Fixes https://github.com/open-telemetry/opamp-go/issues/186

The `OnOpampConnectionSettings` callback documents if the connection fails with the new setting, the offer will be rejected, and the error will be reported to Server. https://github.com/open-telemetry/opamp-go/blob/13a6fd17b28bb7dbbdb9f119db0a0f9acd24994c/client/types/callbacks.go#L80-L84 This `rcvOpampConnectionSettings` doesn't appear...

Related to https://github.com/open-telemetry/opamp-go/pull/174. Client initiated disconnect should set the `agent_disconnect` and send the `AgentToServer` message.

[cmd/opampsupervisor] Fix restart delay when agent process exits unexpectedly

7

**Description:** Reset should called only on stopped or expired timers with drained channels. If the timer already expired (and the channel was not cleared) it reads from the timer's channel...

Generate a `service.instance.id` if it is not present?

3

Spec says https://github.com/open-telemetry/opentelemetry-specification/tree/v1.6.1/specification/resource/semantic_conventions#service > MUST be unique for each instance of the same service.namespace,service.name pair (in other words service.namespace,service.name,service.instance.id triplet MUST be globally unique). The ID helps to distinguish instances...

Removal of materialized column should inspect `system.distribution_queue` before removing local table column

4

## Bug description We should make sure there are no pending items in the `distribution_queue` with the old schema before removing the column from the local table. Why is this...