Srikanth Chekuri

Results 529 comments of Srikanth Chekuri

> > testbaseutils for loading only an api so instrument > > Sorry, can you provide more context, please? All the instrumentation tests inherit this [`TestBase`](https://github.com/open-telemetry/opentelemetry-python/blob/main/tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py#L27). One thing we could...

`None` is allowed. I would personally prefer (None, 42) over ("", "42") because the original type is preserved and you don't have to worry about the type when data reaches...

The spec also says > However, if it is impossible to make sure that no null values are accepted (e.g. in languages that do not have appropriate compile-time type checking),...

It's a lot to review all of these changes at once. Please split the PR into multiple PRs - one for each fix and a new enhancement. It's easier for...

@CoLa5 Please fix the conflicts and split the PR into smaller ones, ideally one of each change for faster reviews.

You can probably do that, but I am afraid you will not complete anything fully.

@Lincoln-developer do you still want to continue this work?