Srikanth Chekuri

Results 417 comments of Srikanth Chekuri

The constant you linked to is not used anywhere in the code.

https://github.com/SigNoz/signoz-otel-collector/pull/307

Specifying your own cluster name is supported.

` 2024-04-12T17:18:22.026Z error clickhousetracesexporter/writer.go:385 Could not append span to batch: {"kind": "exporter", "data_type": "traces", "name": "clickhousetraces", "span": {"traceId": "", "spanId": "", "parentSpanId": "", "name": "TestingSpan", "durationNano": 0, "startTimeUnixNano": 11651379494838206464, "serviceName":...

We now have clarity on the time it takes in each step https://signoz-team.slack.com/archives/C02SGR46RRR/p1714625576474649. We looked into whether async inserts help, the `wait_for_async_insert` setting decides whether we wait till ack. If...

Yes, and you already mentioned the main drawback of the async in the linked issue.

A short length ngram also means there is a scope of false positives in many contexts. Imagine the IP address being part of the body and the IP range is...

Let's change the query service arg to `--cluster-name`.

This is the updated config https://github.com/SigNoz/charts/blob/main/charts/signoz/values.yaml#L1936. You would add `secure=true&skip_verify=true` to the connection string. Example `tcp://${CLICKHOUSE_USER}:${CLICKHOUSE_PASSWORD}@${CLICKHOUSE_HOST}:${CLICKHOUSE_PORT}/${CLICKHOUSE_TRACE_DATABASE}?secure=true&skip_verify=true`

If a PR isn't ready just keep it in draft state. What's the point of marking it ready and requesting reviews when it's not meant to be reviewed?