haskell-flake icon indicating copy to clipboard operation
haskell-flake copied to clipboard

fix: apply 'patches' after 'buildFromSdist'

Open srid opened this issue 1 year ago • 2 comments

Resolves #290

srid avatar Apr 02 '24 06:04 srid

That's a bit surprising. I'd only use buildFromSdist on local packages, and then it doesn't make much sense to add patches. I suppose it could happen when importing a haskell-flake module from a dependency?

I don't have an opinion on whether patches should be applied before or after sdist. When applied before, the patches can be used to fix the creation of the sdist, whereas if you apply them after the sdist, you can fix the effects of a broken sdist. I suppose the latter matches what you would do with a package from hackage, so I guess that might be a reason to prefer that.

roberth avatar Apr 02 '24 12:04 roberth

I'd only use buildFromSdist on local packages

Actually, that makes more sense.

srid avatar Apr 03 '24 00:04 srid