emanote icon indicating copy to clipboard operation
emanote copied to clipboard

Fix og:image path to be absolute

Open TristanCacqueray opened this issue 1 year ago • 2 comments

This change resolves the relative note image path to make an absolute url.

For blog/post.md with a ![img](media/image.png), the og:image is:

  • Before: siteUrl/media/image.png
  • After: siteUrl/blog/media/image.png

TristanCacqueray avatar Jul 01 '24 10:07 TristanCacqueray

cc @shivaraj-bh

srid avatar Jul 01 '24 16:07 srid

In any case, we need to tests before being able to make changes like this.

You are absolutely right, let me convert this to a draft. There are other papercuts in the og:description that I'd like to fix (like wikilink not being rendered properly and the footnote). Is there an example test we could use to validate such fixes?

TristanCacqueray avatar Jul 02 '24 10:07 TristanCacqueray