Sridhar Ratnakumar

Results 611 comments of Sridhar Ratnakumar

@jilleJr Wouldn't it make more sense to upstream `data-ema-reload` (as `data-morphdom-config` for instance) to https://github.com/patrick-steele-idem/morphdom rather than implement it in Ema?

Sorry, I let this comment slip by. > @lucasvreis Would you accept a PR adding the possibility for using a different ema shim (from the haskell side)? Can you elaborate...

More generally, the WebSocket support should probably be decoupled from ema in some fashion so that users can plug in their own stuff if they want.

that's great. if you'd like to help integrate it, [discourse/enter](https://github.com/srid/discourse-docker/blob/c0e3bb30b29a9a510d0b9687f92234b1d1642379/discourse/enter#L52) is the place to look.

I can't reproduce this on my system (macOS; Brave browser). Is this happening only on Firefox? > kasten/_emanote-static/inverted-tree.css Yea, this URL is wrong. Emanote should *never* be generating it (`_emanote-static`...

So this should be reported to Mozilla right? Not sure what emanote can do here.

Ema uses [morphdom](https://github.com/patrick-steele-idem/morphdom) to patch HTML. It could be a bug in morphdom, as morphdom is used only in live-server. https://github.com/EmaApps/ema/blob/ddf0a92d9de8e06906dc5ada2dfc9a00a3153a7e/www/ema-shim.js#L9-L17

It would be great to get this addressed in the upcoming release (https://github.com/EmaApps/emanote/issues/153). Most don't seem to use Firefox, but a substantial number do I believe.

@wbadart Could you try to reproduce this with 74bc63d067bf9971f73a228833c43fe8cb3c3bc4 ?

Replace `???` with `buildInputs = [ emanote.packages.${system}.default ];`. But you can also just run `nix run github:EmaApps/emanote`[^1] on your notebook directory. [^1]: Or `nix run github:EmaApps/emanote/74bc63d067bf9971f73a228833c43fe8cb3c3bc4`