Sridhar Ratnakumar
Sridhar Ratnakumar
Guys, how exactly are we supposed to do layouts in Stubble? Anybody have a working example? I might consider Stubble for https://github.com/srid/Feather/issues/1
About the FAIR pledge, yes that's a problem; not sure what the solution here is. About the `emanote-external` class, that looks fine ... but we should allow the user to...
Sorry I let this slip my radar.
> > Feedback on design: the external link icon should be of grey color (for de-emphasiz) and not of blue ($theme). > > How about this? > >  >...
The generated site should work on browsers with JavaScript disabled. That's another -- and arguably the most important -- reason for the JS injecting icons after page load.
I'll take a look later this week. Been busy.
@kukimik Just took a look at this. - For backlinks, that can be done as part of https://github.com/EmaApps/emanote/issues/187 (not necessarily in this PR) - Your `containsImage` logic doesn't work for...
Behaviorally, the icon looks good to me (and selecting text doesn't select it anymore). Maybe it should be made smaller. What do you mean by "fix the colors"?
Okay, behaviourally things look good to me 👍🏿 Why do we need `NoIcon` differentiation at all? Can't we get rid of it?
@kukimik Basically, I meant removing the `NoIcon` thing entirely. I just tried it out and it works. See https://github.com/EmaApps/emanote/commit/9dee6147e5529beb1f6461915d69909781e9c5dd Do you see any issue with this change? I cannot think...