assign-one-project-github-action icon indicating copy to clipboard operation
assign-one-project-github-action copied to clipboard
verified publisher icon srggrs

Add position input

Open andrenarchy opened this issue 4 years ago • 5 comments

Fixes #54.

andrenarchy avatar Oct 05 '21 09:10 andrenarchy

Hi @andrenarchy thanks for this! Did you tested?

srggrs avatar Oct 06 '21 03:10 srggrs

Yes, I tested this both with position: bottom and without the position input (in which case the request for moving the card is not made so it's backwards-compatible).

andrenarchy avatar Oct 06 '21 17:10 andrenarchy

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

javierm avatar Jul 21 '22 21:07 javierm

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

Please go on and test this functionality thx!

srggrs avatar Jul 27 '22 07:07 srggrs

Hi, @srggrs.

I've tested the andrenarchy/assign-one-project-github-action@master action. Everything seems to work as expected:

  • No parameter: cards are added to the top
  • position: "top": cards are added to the top
  • position: "bottom": cards are added to the top and then moved to the bottom
  • position: "after:<card_id>": cards are added to the top and then moved after the referenced card
  • position: "after:<non_existent_card_id>": cards are added to the top

Out of the (about 15?) tests I've done, only once I've seen a strange behavior: a card was added to the top, then moved to the bottom, and then moved to the top again. I wonder whether it was a mere glitch on github and maybe after refreshing the page the card would have been at the bottom (as expected) :thinking:.

Here's a video showing one of the tests: in this case, draft pull requests are added to the top of the "doing" column (no position parameter) and regular pull requests are added to the bottom of the "reviewing" column (position: "bottom"). Even if there are only two pull requests per column in the video, I've also done tests with more pull requests and it worked fine as well.

After reopening pull requests, they're automatically assigned to the right position in the kanban

Hope this helps!

javierm avatar Aug 22 '22 12:08 javierm