Stephan Renatus

Results 257 comments of Stephan Renatus

LGTM but merging this alone will not update the fig database. We'll have to go through more steps, see the original work done by @developer-guy.

Switching to mermaid would be great! If it's not too much of a hassle for you. If you get stuck with the tests, I'll try to look into them tomorrow.

Still seems like a valuable thing to support. That said, I have not immediate need for it and won't be implementing it. So I guess closing is fine with me...

ℹ️ Should we want to do this, here's an auto-generated protobuf model of OpenAPI v3 (and v2, for that matter): https://github.com/googleapis/gnostic/blob/master/openapiv3/OpenAPIv3.proto

I was thinking that the code generator should catch these -- but really, we could generate a bunch of `.pb.gw.go` files for different services, and end up using them together....

Guess we could make [`(*mux).Handle()`](https://github.com/grpc-ecosystem/grpc-gateway/blob/ae4bb97e7718691c8e0742a7c07989c91630e042/runtime/mux.go#L142-L145) return an error when a pattern clash is detected...

Ok, that will only catch half the trouble, though. You could still have ``` get: "/api/v1/users/{user_id}" ``` in `a.proto`, and ``` get: "/api/v1/users/things" ``` in `b.proto`; generate both `a.pb.gw.go` and...

Looking at the pattern code, it would be nice to come up with a function like ```go func (p Pattern) Overlaps(q Pattern) bool ``` that could then be used; but...

It would be very nice to fix this -- especially with other projects having that constraint, you can quickly run into ``` Solving failure: No versions of github.com/grpc-ecosystem/go-grpc-middleware met constraints:...

@Bplotka Thank you. That's another option indeed. 👍