Sven Reichel comments

Results 458 comments of


                                            Sven Reichel

Cannot exclude products based on special price in Coupon promo.

Up. For some attention.

Rewrote `js/mage/centinel.js` without prototypejs

@fballiano not reviewing these PRs, there are others with more skills in JS. Just to mention ...

Added updated_at column to "System -> Cache Management" grid

Im not against it, but columns can be added via event/observer. Whats the benefit - either cache is up2date or it is not? Btw ... there are some generic events...

Added links to open source files in your IDE when an error occurs

Please split better error messages and editor urls. (btw ... how about ONE env varibale? `EDITOR_URL=`)

Prepare declare strict_types=1

> there are several situations where it changes the behavior of the code I did not see any changes in code behavoir during my tests. (not finished, but 80%) Either...

Adds configurable columns to product grid

Mhh maybe better to fork https://github.com/jayelkaake/enhancedgrid or https://github.com/blmage/mage-enhanced-admin-grids? Btw constants in traits are only for php 8.2.

Adds configurable columns to product grid

> PS: phpstan report that traits cannot have constant, but using self it's ok > i've to implement an interface like that? Think "yes", interface should work. Untested: i guess...

Why "Enable Form Key Validation On Checkout" is set to Yes by default?

Just an idea ... maybe its possible to search custom templates for missing formkey and show this hint depending on it?

Remove deprecated Admin user multirole functionality

> does it need to be in the 19.x releases? Why not remove dead code at all?

Allow to copy ACL and config path

I like it, but do we need this in production mode? Change ``` Mage::getIsDeveloperMode() || Mage::helper('admin/variable')->isPathAllowed($element->getPath()) ``` to ``` Mage::getIsDeveloperMode() && Mage::helper('admin/variable')->isPathAllowed($element->getPath()) ``` What do think?