Sven Rebhan

Results 384 comments of Sven Rebhan

@TimurDela thanks for taking the time to test this! Regarding the `panic` and the `infinite loop`: You cannot set `rearrange` in `TestRequestOptimizationShrink` as it will take forever (thus the panic...

@powersj and @TimurDela if you both agree I would like to first merge this PR and then add #11106 which extends this code in a nice way. This way, #11106...

Hmmm, this seems a lot of code to just leave out two fields... This being said, the `HELP` part can already be left-out with the upstream encoder by not setting...

@vpedosyuk I see your point and agree that it would be nice to remove the noise if that's still conforming to the spec, but I do not agree with your...

@ShiranAvidov thanks for looking into the SDK. Please also note that they have zillions of packages, so if you miss some functionality maybe also look at the neighboring packages. :-)...

Honestly speaking an integration would require to dramatically reduce the code size by either using existing libraries or move the inner mechanisms to a "high-level" library hiding the complexity. The...

@infa-pavakuma as stated earlier, the PR needs a revamp to reduce the amount of code by either using existing libraries or by moving most of the inner workings to a...

@ShiranAvidov and @ZPascal please keep this going! Just ping me if you need my input...

Hey @ShiranAvidov, is there a chance you can address my comments?

@Hipska what did you expect? We only remove "empty" plugin hulls from the build so a huge change in size cannot be expected. Please note, this is not a check...