Stig Døssing

Results 40 comments of Stig Døssing

@jainrish If you think a configuration for time unit would be useful, feel free to add it. Up to you whether to do it in this PR or in a...

Looks good, just a few minor nits left: Please add the default setting to https://github.com/apache/storm/blob/master/conf/defaults.yaml. That way it's visible to users what the default is. Then you can remove the...

@thirtyseven Thanks for looking into this. We've been discussing this issue over [here](https://github.com/bazelbuild/rules_scala/issues/1521#issuecomment-1789002782). I think the version detection you mention has become available in `JavaRuntimeInfo`, there's an example here of...

@simuons I don't understand why adjusting the Java toolchain would be the only option other than removing the exit trap? Can't we detect the Java version from Starlark in the...

Would have been nice if whoever enabled this also sent out communication about it. The http://go/allstar link is dead, am assuming it's an internal Google link? Do jars used only...

The reason I didn't fix this when I reported https://github.com/bazelbuild/rules_scala/issues/1425 is that it's a little more complicated than just adding `-Djava.security.manager=allow` to the places we invoke Java :) Adding this...

I believe the JDK team [are aware](https://bugs.openjdk.org/browse/JDK-8199704) that trapping `System.exit` is a common reason people use the SM, and so I would expect there to be a replacement in the...

> On a different note, after my initial investigations I'm not sure enabling SecurityManager will be all we need to change. You are right, but for the basic functionality of...

@mattnworb Yes, before Java 22, `ct.sym` doesn't contain symbols for the current JDK, so you can't pass `--release 21` to Java 21, because Turbine won't know where to find the...