Stig Døssing

Results 46 comments of Stig Døssing

No, but like I said, I suspect that the exit code is being set by a call to `Utils.exitProcess`. If you try changing some of the exit codes to be...

Unless it turns out to be easy to fix the test errors, I'd like to propose not merging this and fixing this issue as part of making the metrics registry...

It should. Take a look at https://github.com/srdo/storm/compare/892179527b5a...0916fae11cb2#diff-9c4945e8e924565ca1f071435f4711e9. If you compare the daemon classes (Nimbus, Supervisor etc.) there should be a call to stopMetricsReporters in all of them, that should stop...

I've added calls to report to the branch, the tests are running at https://travis-ci.org/srdo/storm/builds/413332618. Unless the test specifies another configuration file, I would expect us to be using https://github.com/apache/storm/blob/master/conf/defaults.yaml. I...

Before spending too long on it, consider if we should fix this issue and https://github.com/apache/storm/pull/2714 by making the metrics registry non-static instead (https://github.com/apache/storm/pull/2783). I think it will be much easier...

Once the two PRs with new metrics are merged, I'll try to update the non-static branch and get a PR opened. It might take me a little while.

The change is here https://github.com/apache/storm/pull/2805 and hasn't been merged yet.

@zd-project I'm happy to take a look at implementing https://github.com/apache/storm/pull/2764 once the non-static PR is merged. I don't think it makes sense to mix more stuff into the current PR,...

I think the ScheduledStormReporter classes are for the metrics reporters for the workers (the parts topologies can hook into), while this is for the daemons. I think having separate parameters...