sourced-ce icon indicating copy to clipboard operation
sourced-ce copied to clipboard

Add unit tests

Open carlosms opened this issue 4 years ago • 6 comments

We should have as many unit tests as makes sense. When possible, all features that can be tested with unit tests instead of integration tests will save time.

carlosms avatar Aug 06 '19 10:08 carlosms

I added tests to internal packages. My idea was to also add some tests for cmd package with mocked docker dependency but as I'm not working on it right now, I'm returning the issue into todo.

smacker avatar Oct 01 '19 10:10 smacker

@kyrcha will start looking into this so that we can also familiarize with the project. @kyrcha do you mind self-assigning yourself this card then?

se7entyse7en avatar Oct 01 '19 10:10 se7entyse7en

@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself? Related issue: src-d/metadata-retrieval#13

kyrcha avatar Oct 01 '19 10:10 kyrcha

@se7entyse7en Sure. Could you add the QA team to the repo and also to the metadata because I cannot do the assignment myself?

\cc @smola what's the policy here? maybe QA should be part of all repos by default?

se7entyse7en avatar Oct 01 '19 11:10 se7entyse7en

@kyrcha I'll manually add you for now 👍

se7entyse7en avatar Oct 01 '19 12:10 se7entyse7en

@se7entyse7en We have pending some automation of GitHub permissions by infra. Other than that, please add QA team with Write permission to any repository on demand. Thanks!

smola avatar Oct 02 '19 08:10 smola