kmcuda icon indicating copy to clipboard operation
kmcuda copied to clipboard

Update python.cc

Open mooresethmoore opened this issue 2 years ago • 4 comments

Missing surrounding parenthesis for if statement on PyTuple_Check for python 3.9 or some versions of DCMAKE or CUDA_ARCH causes a build error.

Signed-off-by: Seth Moore [email protected]

mooresethmoore avatar Jan 28 '22 22:01 mooresethmoore

Thanks, @mooresethmoore! Would you kindly sign the DCO.

vmarkovtsev avatar Jan 30 '22 07:01 vmarkovtsev

Compiled successfully with this patch. Thank you!

lvyilin avatar Feb 07 '22 09:02 lvyilin

@vmarkovtsev are there any plans on merging this? It solved my compilation problem under python 3.9.

vincent-mayer avatar Sep 19 '22 15:09 vincent-mayer

@vincentmaye If you could copy this fix in another PR and accept DCO, I will immediately merge it :pray: You see, I've got a strong requirement for license purity and cannot accept patches without signed-off-by.

vmarkovtsev avatar Sep 19 '22 16:09 vmarkovtsev