go-kallax icon indicating copy to clipboard operation
go-kallax copied to clipboard

fix #296 - add go modules support

Open s-kostyaev opened this issue 5 years ago • 3 comments

Add go modules support with golang.org/x/tools/go/packages

s-kostyaev avatar Jul 05 '19 18:07 s-kostyaev

This works nicely for me.

I had to change the generate command to //go:generate go run gopkg.in/src-d/go-kallax.v1/generator/cli/kallax gen. It would be good to document this requirement in the readme.

And for anyone else wanting to test I added a temporary line to my go.mod file to use this PR: replace gopkg.in/src-d/go-kallax.v1 => github.com/s-kostyaev/go-kallax v1.3.6-0.20190705185553-021d805e3744

Julusian avatar Jul 17 '19 18:07 Julusian

Confirming, works good. It just needs to be confirmed to be working for non-mod projects for backward compat

iorlas avatar Jul 24 '19 05:07 iorlas

@roobre, can you help to fix the failing tests?

felipemfp avatar Aug 27 '19 20:08 felipemfp